Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support New Subnet Backbone #13179

Merged
merged 19 commits into from
Dec 8, 2023
Merged

Support New Subnet Backbone #13179

merged 19 commits into from
Dec 8, 2023

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 7, 2023

What type of PR is this?

Feature

What does this PR do? Why is it needed?

  • Supports new subnet computation based on node-id.
  • Removes previous subscription based on hosted validator counts.
  • Adds tests for the new features added in

This PR does not gate this feature via a flag as this has been run for a while with other clients. In a follow up PR, new metrics and a flag to increase subnet subscription count will also be added in.

Which issues(s) does this PR fix?

Fixes #12715

Other notes for review

@nisdas nisdas added Ready For Review A pull request ready for code review Networking P2P related items labels Nov 7, 2023
@nisdas nisdas requested a review from a team as a code owner November 7, 2023 14:25
@nisdas nisdas added the Blocked Blocked by research or external factors label Nov 29, 2023
@nisdas nisdas removed the Blocked Blocked by research or external factors label Dec 6, 2023
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nisdas nisdas added this pull request to the merge queue Dec 8, 2023
Merged via the queue into develop with commit 5903175 Dec 8, 2023
17 checks passed
@nisdas nisdas deleted the newSubnetBackbone branch December 8, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Networking P2P related items Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift Subnet Backbone Structure in Prysm
2 participants