Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BN: Move --db-backup-output-dir as a deprecated flag. #13450

Merged
merged 1 commit into from Jan 11, 2024
Merged

Conversation

nalepae
Copy link
Contributor

@nalepae nalepae commented Jan 11, 2024

What type of PR is this?
Bug fix

What does this PR do? Why is it needed?
No functional change.

New --help output:

...
interop OPTIONS:
   --genesis-state value           Load a genesis state from ssz file. Testnet genesis files can be found in the eth2-clients/eth2-testnets repository on github.
   --interop-genesis-time value    Specify the genesis time for interop genesis state generation. Must be used with --interop-num-validators (default: 0)
   --interop-num-validators value  Specify number of genesis validators to generate for interop. Must be used with --interop-genesis-time (default: 0)

deprecated OPTIONS:
   --db-backup-output-dir value  Output directory for db backups.

I do not remove this flag not to break compatibility.

An other PR in documentation will remove the section for BN DB backup.

Which issues(s) does this PR fix?
Fixes #13449

@nalepae nalepae requested a review from a team as a code owner January 11, 2024 13:25
@nalepae nalepae added this pull request to the merge queue Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2024
@nalepae nalepae added this pull request to the merge queue Jan 11, 2024
Merged via the queue into develop with commit a883ae2 Jan 11, 2024
17 checks passed
@nalepae nalepae deleted the backup-13449 branch January 11, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beacon node: --enable-db-backup-webhook does not exists.
2 participants