Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issue in blsToExecChange message validator #13498

Merged
merged 2 commits into from Jan 23, 2024

Conversation

jtraglia
Copy link
Contributor

@jtraglia jtraglia commented Jan 22, 2024

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Small fix in postAltairMsgID which used the wrong domain when calculating length; was using ValidSnappy in length calculation and using InvalidSnappy later. It doesn't make a difference though because both domains are the same length, four bytes. Just fixing to fix.
  • Fix a typo in a comment about blob requests.
  • The primary reason for this PR: check that blsChange.Message isn't nil before derefencing it. The gossip topic message validators, like this one, will recover from any panic. So Prysm won't crash, but it will print an annoying panic stack trace to the console.

@jtraglia jtraglia requested a review from a team as a code owner January 22, 2024 21:36
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks again justin, will let others know to take a look too if needed

Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Catch !

@nisdas nisdas enabled auto-merge January 23, 2024 03:06
@nisdas nisdas added this pull request to the merge queue Jan 23, 2024
Merged via the queue into prysmaticlabs:develop with commit 4e24102 Jan 23, 2024
17 checks passed
@jtraglia jtraglia deleted the prevent-annoying-panic-msg branch January 23, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants