Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add BlockBatchLimit comment: Maximum 128 #13502

Merged
merged 3 commits into from Feb 15, 2024
Merged

add BlockBatchLimit comment: Maximum 128 #13502

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf04868
add BlockBatchLimit comment: Maximum 128
tmors Jan 23, 2024
607d8eb
Merge branch 'develop' into develop
james-prysm Jan 23, 2024
f64bf9c
Merge branch 'develop' into develop
james-prysm Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/beacon-chain/flags/base.go
View file
Open in desktop
Expand Up @@ -158,7 +158,7 @@ var (
// BlockBatchLimit specifies the requested block batch size.
BlockBatchLimit = &cli.IntFlag{
Name: "block-batch-limit",
Usage: "The amount of blocks the local peer is bounded to request and respond to in a batch.",
Usage: "The amount of blocks the local peer is bounded to request and respond to in a batch. Maximum 128",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This number changes depending on network so just saying maximum 128 might not be great, we should think of a better way to word this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. It seems that it's not so good to word this here because the range is dynamic.
What about adding param judgement on the fetchBlocksFromPeer to make user can realize it without enable the Debug otherwise user would keep waiting here because there is no any error msg . like this :

maxRequest := params.MaxRequestBlock(slots.ToEpoch(start))
if count > maxRequest {
    log.WithField("count", count).WithField("maxRequest", maxRequest).Error("Requested count is too high, reducing")
}

Value: 64,
}
// BlockBatchLimitBurstFactor specifies the factor by which block batch size may increase.
Expand Down