Add /eth/v1/beacon/deposit_snapshot endpoint
#13514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
changed the title
/eth/v1/beacon/deposit_snapshot endpoint
james-prysm
reviewed
Jan 23, 2024
james-prysm
reviewed
Jan 23, 2024
james-prysm
reviewed
Jan 23, 2024
james-prysm
previously approved these changes
Jan 24, 2024
james-prysm
reviewed
Jan 31, 2024
james-prysm
reviewed
Jan 31, 2024
james-prysm
reviewed
Feb 5, 2024
prestonvanloon
requested changes
Feb 6, 2024
rkapka
reviewed
Feb 6, 2024
rkapka
requested changes
Feb 7, 2024
api/server/structs/conversions.go
Outdated
| func DepositSnapshotFromConsensus(ds *eth.DepositSnapshot) *DepositSnapshot { | ||
| finalized := make([]string, 0, len(ds.Finalized)) | ||
| for i, f := range ds.Finalized { | ||
| if i >= depositsnapshot.DepositContractDepth { |
There was a problem hiding this comment.
This function should not have logic in it, it should purely convert between types. You should check the length of the returned value inside the handler. Although I find it peculiar that we add constraints to a returned value, I guess it might be OK as an indication that we have a bug somewhere in the deposit snapshot code.
There was a problem hiding this comment.
You are right, I have modified it to check ahead of time as if the length of finalized exceeds the deposit contract depth we likely have an invalid snapshot
prestonvanloon
approved these changes
Feb 7, 2024
james-prysm
approved these changes
Feb 7, 2024
rkapka
approved these changes
Feb 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds the missing endpoint to retrieve deposit snapshot data.
https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getDepositSnapshot