Add beacon block proto #13584
Merged
Add beacon block proto #13584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
requested review from
nalepae and
terencechain
and removed request for
a team
terencechain
reviewed
Feb 5, 2024
Comment on lines
95
to
109
| // Eth1Data represents references to the Ethereum 1.x deposit contract. | ||
| message Eth1Data { | ||
| // The 32 byte deposit tree root for the last deposit included in this | ||
| // block. | ||
| bytes deposit_root = 1 [(ethereum.eth.ext.ssz_size) = "32"]; | ||
|
|
||
| // The total number of deposits included in the beacon chain since genesis | ||
| // including the deposits in this block. | ||
| uint64 deposit_count = 2; | ||
|
|
||
| // The 32 byte block hash of the Ethereum 1.x block considered for deposit | ||
| // inclusion. | ||
| bytes block_hash = 3 [(ethereum.eth.ext.ssz_size) = "32"]; | ||
| } | ||
|
|
There was a problem hiding this comment.
Why did we move these from L271-L285?
There was a problem hiding this comment.
Sorry, tried to decouple the proto files and moved Eth1 data to another file, but in the end the dependencies of slashings with headers make it impossible to have different files for protos on blocks. Desisted on finding the right place again :)
proto/prysm/v1alpha1/eth1_data.proto
Outdated
| option php_namespace = "Ethereum\\Eth\\v1alpha1"; | ||
|
|
||
| // Eth1Data represents references to the Ethereum 1.x deposit contract. | ||
| message Eth1Data { |
There was a problem hiding this comment.
Why did we have to add this file?
There was a problem hiding this comment.
ahh crap this file should be removed, forgot about it... doing it now
potuz
force-pushed
the
epbs-core-struct-protos
branch
from
634307c
to
d816a74
Compare
potuz
force-pushed
the
epbs-core-struct-protos
branch
from
d816a74
to
6a724ab
Compare
terencechain
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the beacon block protos for ePBS.
This last item differs from the current design in potuz/consensus-specs#1 as discussed offline.