Remove deprecated items #13600
Remove deprecated items #13600
Conversation
rkapka
added
Cleanup
| @@ -173,7 +173,7 @@ func TestGetSpec(t *testing.T) { | |||
| data, ok := resp.Data.(map[string]interface{}) | |||
| require.Equal(t, true, ok) | |||
|
|
|||
| assert.Equal(t, 132, len(data)) | |||
There was a problem hiding this comment.
what changed here? was this just broken?
There was a problem hiding this comment.
I removed DeprecatedSafeSlotsToUpdateJustified and DeprecatedSafeSlotsToImportOptimistically from config/params/config.go
| @@ -809,9 +735,7 @@ message GetValidatorParticipationRequest { | |||
| } | |||
| } | |||
|
|
|||
| // DEPRECATED: Prysm Web UI and associated endpoints will be fully removed in a future hard fork. | |||
There was a problem hiding this comment.
also global participation rate should be looked at above
There was a problem hiding this comment.
the e2e can be fixed regarding it
There was a problem hiding this comment.
I don't understand this comment. We can't remove validator participation because it's not marked as deprecated.
There was a problem hiding this comment.
validator participating is not deprecated but there are fields in it that are
float global_participation_rate = 1 [deprecated = true]; for example
| @@ -809,9 +735,7 @@ message GetValidatorParticipationRequest { | |||
| } | |||
| } | |||
|
|
|||
| // DEPRECATED: Prysm Web UI and associated endpoints will be fully removed in a future hard fork. | |||
| message ValidatorParticipationResponse { | |||
There was a problem hiding this comment.
we aren't using validator participating in webui anymore I think...
There was a problem hiding this comment.
unfortunately it's not marked as deprecated
There was a problem hiding this comment.
? the option deprecated = true got removed here , I don't understand why it's not marked as deprecated
proto/prysm/v1alpha1/validator.proto
Outdated
| repeated Duty duties = 1 [deprecated = true]; | ||
|
|
||
| repeated Duty current_epoch_duties = 2; | ||
| repeated Duty current_epoch_duties = 1; |
There was a problem hiding this comment.
Avoid changing message IDs.
| repeated Duty current_epoch_duties = 1; | |
| reserved 1; // Deprecated fields | |
| repeated Duty current_epoch_duties = 2; |
proto/prysm/v1alpha1/validator.proto
Outdated
|
|
||
| repeated Duty next_epoch_duties = 3; | ||
| repeated Duty next_epoch_duties = 2; |
There was a problem hiding this comment.
Avoid changing message IDs.
| repeated Duty next_epoch_duties = 2; | |
| repeated Duty next_epoch_duties = 3; |
| @@ -228,6 +185,7 @@ service BeaconChain { | |||
| // validator attestations. This endpoint allows for retrieval of genesis | |||
| // information via a boolean query filter. | |||
| rpc GetValidatorParticipation(GetValidatorParticipationRequest) returns (ValidatorParticipationResponse) { | |||
| option deprecated = true; | |||
There was a problem hiding this comment.
Is this newly deprecated?
There was a problem hiding this comment.
Yes, we had a discussion i wanted to get rid of it but realized we don't have it deprecated yet...
The ones I didn't remove are still used. It might be possible to rewrite these usages in terms of the HTTP event stream, but it's too late to do this now. |
# Conflicts: # beacon-chain/rpc/prysm/v1alpha1/beacon/attestations.go # beacon-chain/rpc/prysm/v1alpha1/beacon/attestations_test.go # beacon-chain/rpc/prysm/v1alpha1/beacon/blocks.go # beacon-chain/rpc/prysm/v1alpha1/beacon/blocks_test.go # beacon-chain/rpc/prysm/v1alpha1/beacon/validators_stream.go # beacon-chain/rpc/prysm/v1alpha1/beacon/validators_stream_test.go # beacon-chain/rpc/prysm/v1alpha1/validator/duties.go # beacon-chain/rpc/prysm/v1alpha1/validator/duties_test.go # cmd/prysmctl/deprecated/BUILD.bazel # cmd/prysmctl/deprecated/checkpoint/BUILD.bazel # cmd/prysmctl/deprecated/cmd.go # cmd/prysmctl/main.go # proto/prysm/v1alpha1/beacon_block.pb.go # proto/prysm/v1alpha1/beacon_chain.pb.go # proto/prysm/v1alpha1/debug.pb.go # proto/prysm/v1alpha1/validator.pb.go # testing/mock/beacon_chain_service_mock.go # testing/mock/beacon_service_mock.go # testing/mock/beacon_validator_client_mock.go # testing/mock/beacon_validator_server_mock.go
What type of PR is this?
Cleanup