Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Race on the background FCU call #13602

Merged
merged 1 commit into from Feb 13, 2024
Merged

Data Race on the background FCU call #13602

merged 1 commit into from Feb 13, 2024

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Feb 9, 2024

The call to computePayloadAttributes needs a forkchoice lock because of the following path:

computePayloadAttributes->updateCachesPortBlockProcessing->handleEpochBoundary->updateEpochBoundaryCaches-> TargetRootForEpoch

@potuz potuz added the Bug Something isn't working label Feb 9, 2024
@potuz potuz requested a review from a team as a code owner February 9, 2024 15:38
@potuz potuz enabled auto-merge February 9, 2024 17:28
@potuz potuz added this pull request to the merge queue Feb 13, 2024
Merged via the queue into develop with commit 8a89173 Feb 13, 2024
17 checks passed
@potuz potuz deleted the second_fcu_datarace branch February 13, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@potuz potuz

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@potuz @prestonvanloon