Normalize checkpoint logs. #13643
Merged
Normalize checkpoint logs. #13643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Feb 21, 2024
api/client/beacon/checkpoint_test.go
Outdated
| @@ -35,7 +35,7 @@ func (rt *testRT) RoundTrip(req *http.Request) (*http.Response, error) { | |||
| if rt.rt != nil { | |||
| return rt.rt(req) | |||
| } | |||
| return nil, errors.New("RoundTripper not implemented") | |||
There was a problem hiding this comment.
RoundTripper is a type, so it might be better to leave it as uppercase
nalepae
force-pushed
the
checkpoint-logs
branch
from
3caa305
to
b313534
Compare
kasey
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
Makes chekpoint logs and errors consistent with the rest of the system:
log.gofile with a common prefixedlogvariable