Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify log fields #13654

Merged
merged 2 commits into from Feb 22, 2024
Merged

Unify log fields #13654

merged 2 commits into from Feb 22, 2024

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Feb 22, 2024

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

Makes all log fields camelCase

@rkapka rkapka added Ready For Review A pull request ready for code review Cleanup Code health! labels Feb 22, 2024
@rkapka rkapka requested a review from a team as a code owner February 22, 2024 19:45
@@ -111,7 +111,7 @@ func (s *Service) Start() {
sort.Slice(tracked, func(i, j int) bool { return tracked[i] < tracked[j] })

log.WithFields(logrus.Fields{
"ValidatorIndices": tracked,
"validatorIndices": tracked,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here: validatorIndices, and in another place validatorIndex.

@rkapka rkapka added this pull request to the merge queue Feb 22, 2024
Merged via the queue into develop with commit 0b261cb Feb 22, 2024
17 checks passed
@rkapka rkapka deleted the unify-log-fields branch February 22, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health! Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants