Download checkpoint sync origin blobs in init-sync #13665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
requested review from
rauljordan,
potuz,
nisdas and
terencechain
and removed request for
rauljordan
prestonvanloon
approved these changes
Feb 26, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
Mar 1, 2024
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com> (cherry picked from commit 0132c1b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
With this PR a checkpoint synced node will fetch blobs for the checkpoint sync origin block in initial-sync before entering round robin sync. This ensures that the node can guarantee availability of the checkpoint sync blobs before participating in the gossip protocol.
Other notes for review
We could have fetched blobs from the checkpoint sync provider beacon node instead, but this approach seemed more robust, since it doesn't assume public beacon node apis will provide blobs.