keymanager api: lowercase statuses #13696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
API
terencechain
previously approved these changes
Mar 6, 2024
nalepae
reviewed
Mar 6, 2024
validator/rpc/handlers_keymanager.go
Outdated
| @@ -479,7 +479,7 @@ func (s *Server) ImportRemoteKeys(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
| } | |||
| if isUrlUsed { | |||
| log.Warnf("Setting web3signer base url for IMPORTED keys is not supported. Prysm only uses the url from --validators-external-signer-url flag for web3signerKeymanagerKind.") | |||
| log.Warnf("Setting the remote signer base url within the request is not supported. The remote signer url can only be set from the --validators-external-signer-url flag.") | |||
There was a problem hiding this comment.
Is it possible to use "... %s", flags.XXX.name instead of this hard coded flag in case we change the flag?
nalepae
previously approved these changes
Mar 6, 2024
nalepae
approved these changes
Mar 6, 2024
rkapka
pushed a commit
that referenced
this pull request
Mar 7, 2024
* cleanup * adding test * address small comment * gaz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
statuses should be in lowercase for keymanager APIs
note: additional cleanup on keymanager APIs