Optimize SubscribeCommitteeSubnets VC action
#13702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
force-pushed
the
optimize-SubscribeCommitteeSubnets
branch
from
e8dc90a
to
818d075
Compare
rkapka
added
Ready For Review
james-prysm
reviewed
Mar 7, 2024
| @@ -3899,7 +3899,7 @@ var file_proto_prysm_v1alpha1_beacon_block_proto_rawDesc = []byte{ | |||
| 0x64, 0x72, 0x61, 0x77, 0x61, 0x6c, 0x73, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x1a, 0x26, 0x70, | |||
| 0x72, 0x6f, 0x74, 0x6f, 0x2f, 0x65, 0x6e, 0x67, 0x69, 0x6e, 0x65, 0x2f, 0x76, 0x31, 0x2f, 0x65, | |||
| 0x78, 0x65, 0x63, 0x75, 0x74, 0x69, 0x6f, 0x6e, 0x5f, 0x65, 0x6e, 0x67, 0x69, 0x6e, 0x65, 0x2e, | |||
| 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x22, 0xf4, 0x05, 0x0a, 0x18, 0x47, 0x65, 0x6e, 0x65, 0x72, 0x69, | |||
| 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x22, 0xee, 0x05, 0x0a, 0x18, 0x47, 0x65, 0x6e, 0x65, 0x72, 0x69, | |||
There was a problem hiding this comment.
Why was this file changed if no proto changed?
nalepae
reviewed
Mar 8, 2024
| @@ -537,6 +537,8 @@ message DutiesResponse { | |||
|
|
|||
| // Whether the validator belongs in the sync committee and has to perform sync committee duty. | |||
| bool is_sync_committee = 8; | |||
|
|
|||
| uint64 committees_at_slot = 9; | |||
There was a problem hiding this comment.
All other values in this file have a comment.
| @@ -95,6 +95,11 @@ func (c beaconApiValidatorClient) getDutiesForEpoch( | |||
| if err != nil { | |||
| return nil, errors.Wrapf(err, "failed to get committees for epoch `%d`", epoch) | |||
| } | |||
| slotCommittees := make(map[string]uint64) | |||
| for _, c := range committees { | |||
| n := slotCommittees[c.Slot] | |||
There was a problem hiding this comment.
Even if this works correctly, I think it would be better to explicitly handle the case where c.Slot is not in slotCommittees, instead of relying on the default missing value of uint64.
Something like
for _, c := range committees {
n, ok := slotCommittees[c.Slot]
if !ok {
n = 0
}
slotCommittees[c.Slot] = n + 1
}
nalepae
approved these changes
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
james-prysm
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
SubscribeCommitteeSubnetsin the REST VC takes around 1-2 seconds. Almost all of this time is spend on fetching duties to get the number of committees in a slot, but we already return this value when fetching duties at the beginning of the epoch, we just need to pass it into the function. Addingcommittees_at_slotto the duty proto message allows us to have this value available.This reduces the time needed to subscribe from 1-2 seconds to 1 millisecond.