Blob verification spectest #13707
Merged
Blob verification spectest #13707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
reviewed
Mar 8, 2024
beacon-chain/verification/blob.go
Outdated
| @@ -261,7 +277,7 @@ func (bv *ROBlobVerifier) SidecarDescendsFromFinalized() (err error) { | |||
| func (bv *ROBlobVerifier) SidecarInclusionProven() (err error) { | |||
| defer bv.recordResult(RequireSidecarInclusionProven, &err) | |||
| if err = blocks.VerifyKZGInclusionProof(bv.blob); err != nil { | |||
| log.WithError(err).WithFields(logging.BlobFields(bv.blob)).Debug("sidecar inclusion proof verification failed") | |||
| log.WithError(err).WithFields(logging.BlobFields(bv.blob)).Error("sidecar inclusion proof verification failed") | |||
There was a problem hiding this comment.
Sorry, I changed this to Error in my PR. I think we can revert this back to Debug
kasey
force-pushed
the
blob-verification-spectest
branch
from
ab4bbf8
to
069786b
Compare
beacon-chain/verification/blob.go
Outdated
Comment on lines
56
to
57
| //RequireSidecarParentSeen, | ||
| //RequireSidecarParentValid, |
There was a problem hiding this comment.
Did you mean to comment these out?
If so, consider adding some method like
var SpectestSidecarRequirements = xor(GossipSidecarRequirements, []Requirement{
// Requiring parent checks in spectest is not possible.
RequireSidecarParentSeen,
RequireSidecarParentValid,
})This way we won't have to ensure two slices are updated in the future.
There was a problem hiding this comment.
implemented this, please take a look!
fwiw the main downside I see is that it makes it a little hard to make out what requirements you're keeping for lists where you're excluding most things, like initial-sync/backfill. but otherwise I'm good with it if you are.
kasey
force-pushed
the
blob-verification-spectest
branch
3 times, most recently
from
58de343
to
8023ea0
Compare
terencechain
previously approved these changes
Mar 8, 2024
kasey
force-pushed
the
blob-verification-spectest
branch
from
8023ea0
to
4a697a1
Compare
prestonvanloon
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This fixes an oversight in our spectest coverage that was not exercising blob verification paths in the forkchoice tests. This issue was further compounded by a test Skip in the spectests. This PR unskips the on_block tests and sets up the necessary dependencies to verify blobs like sync.