Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(execution): Clean up unreachable code; use new(big.Int) instead of big.NewInt(0) #13715

Merged
merged 2 commits into from Mar 11, 2024
Merged

chore(execution): Clean up unreachable code; use new(big.Int) instead of big.NewInt(0) #13715

merged 2 commits into from Mar 11, 2024

Conversation

letonchanh
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Clean up unreachable code inside an if statement with an always-false condition.
  • Use new(big.Int), which is more efficient than big.NewInt(0).
  • Use built-in max/min functions, supported since Go 1.21.

Which issues(s) does this PR fix?

No issues have been fixed in this PR—only code improvement.

Other notes for review

@letonchanh letonchanh requested a review from a team as a code owner March 10, 2024 15:53
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

nisdas
nisdas approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@nisdas nisdas added this pull request to the merge queue Mar 11, 2024
Merged via the queue into prysmaticlabs:develop with commit 800f3b5 Mar 11, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@letonchanh @CLAassistant @nisdas