Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bazel, rules_go, gazelle, and go versions #13724

Merged
merged 2 commits into from Mar 12, 2024
Merged

Update bazel, rules_go, gazelle, and go versions #13724

merged 2 commits into from Mar 12, 2024

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Mar 12, 2024 •
edited

What type of PR is this?

Other

What does this PR do? Why is it needed?

Updating bazel related items and Go to the latest patch version

Which issues(s) does this PR fix?

Other notes for review

Also updates zig toolchain

@prestonvanloon prestonvanloon requested a review from a team as a code owner March 12, 2024 00:54
saolyn
saolyn approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestonvanloon prestonvanloon added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit e19c99c Mar 12, 2024
17 checks passed
@prestonvanloon prestonvanloon deleted the update-bazel-go branch March 12, 2024 14:59
@prestonvanloon
Copy link
Member Author

Adding this impact report

# Before
bazelisk build //...  0.48s user 0.37s system 0% cpu 33:27.21 total

# After
bazelisk build //...  0.11s user 0.08s system 0% cpu 6:40.15 total

About a x5 improvement on build times with two partially remote cached builds. Something was really wrong with GoLink, I suspect in the zig toolchain.

@prestonvanloon prestonvanloon mentioned this pull request Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn saolyn approved these changes

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prestonvanloon @saolyn