Save invalid blob to temp under new flag #13725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
invalid-blob-flag
branch
from
d2dd125
to
889a5db
Compare
kasey
reviewed
Mar 12, 2024
| @@ -46,6 +46,10 @@ var ( | |||
| Name: "save-invalid-block-temp", | |||
| Usage: "Writes invalid blocks to temp directory.", | |||
| } | |||
| saveInvalidBlobTempFlag = &cli.BoolFlag{ | |||
| Name: "save-invalid-blob-temp", | |||
| Usage: "Writes invalid blobs to temp directory.", | |||
There was a problem hiding this comment.
Should this mention "gossip" since this doesn't apply to init-sync or backfill? (Same q for --save-invalid-block-temp)
kasey
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR saves an invalid blob to temp under
--save-invalid-blob-temp. Here the invalid blob is defined by failingSidecarKzgProofVerified, we would still perform the proposer signature beforehand to prevent invalid spamming