Electra: EIP-7251 update process_pending_balance_deposits
#14177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The logic looks correct. One thing I noticed is that you annotated your code with some spec's comments, but not all of them |
Thanks @rkapka, I've add the rest of the spec commentary for consistency. |
prestonvanloon
force-pushed
the
electra-update-process_pending_balance_deposits
branch
from
7473388
to
769687f
Compare
terencechain
approved these changes
Jul 3, 2024
rkapka
approved these changes
Jul 4, 2024
prestonvanloon
deleted the
electra-update-process_pending_balance_deposits
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Updates
process_pending_balance_depositsto match v1.5.0-alpha.3 spec with changes from ethereum/consensus-specs#3776.Which issues(s) does this PR fix?
Other notes for review