Add Aggregated Public Key Method #14178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
reviewed
Jul 3, 2024
| pubKeys := make([][]byte, len(idxs)) | ||
| for i, idx := range idxs { | ||
| var v *ethpb.Validator | ||
| if features.Get().EnableExperimentalState { |
There was a problem hiding this comment.
This case is not tested at all, is it expected?
There was a problem hiding this comment.
I think its fine in this particular case as its simply for the experimental state, we don't do the same for a few other methods too. Also the experimental state has been tested in e2e, so these paths are tested, just not in the current unit tests. Once we flip the flag, it will get tested as it becomes the default path
nalepae
reviewed
Jul 3, 2024
| pubkeys[i] = pubkeyAtIdx[:] | ||
| } | ||
| aggP, err := bls.AggregatePublicKeys(pubkeys) | ||
| aggP, err := beaconState.AggregatedKeyFromIndices(indices) |
There was a problem hiding this comment.
Nit: The previous function is AggregatePublicKeys. Should'nt this function name AggregateKeyFromIndices?
terencechain
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
Currently for each attestation aggregate we allocate memory for each individual public key when trying to derive the aggregated key. To optimize this process we simply collect all the keys in the state's receiver and aggregate it there itself. The main benefit of this is to completely avoid memory-allocation in a known hot-path in gossip.
Which issues(s) does this PR fix?
N.A
Other notes for review