Activate PeerDAS with the EIP7594 Fork Epoch #14184
Conversation
nisdas
added
Ready For Review
nisdas
requested review from
saolyn,
terencechain and
rkapka
and removed request for
a team
| @@ -53,6 +53,11 @@ func HigherEqualThanAltairVersionAndEpoch(s state.BeaconState, e primitives.Epoc | |||
| return s.Version() >= version.Altair && e >= params.BeaconConfig().AltairForkEpoch | |||
| } | |||
|
|
|||
| // PeerDASIsActive checks whether peerDAS is active at the provided slot. | |||
| func PeerDASIsActive(slot primitives.Slot) bool { | |||
There was a problem hiding this comment.
PeerDASIsActive ==> isPeerDASActive?
(This convention seems to be used in other places in the code and indicates clearly the function returns a bool.)
There was a problem hiding this comment.
I like the current version more because if you write if PeerDasIsActive() then it reads very smoothly. But we don't have a rule for this
There was a problem hiding this comment.
I was following from terms like DenebEnabled as a guide rather than posing it as a question. I don't feel too strongly but if we do start using isPeerDASActive I would prefer it to be standardized for all similar functions.
config/params/config.go
Outdated
| ElectraForkVersion []byte `yaml:"ELECTRA_FORK_VERSION" spec:"true"` // ElectraForkVersion is used to represent the fork version for deneb. | ||
| ElectraForkEpoch primitives.Epoch `yaml:"ELECTRA_FORK_EPOCH" spec:"true"` // ElectraForkEpoch is used to represent the assigned fork epoch for deneb. | ||
| Eip7594ForkEpoch primitives.Epoch `yaml:"EIP7594_FORK_EPOCH" spec:"true"` // EIP7594ForkEpoch is used to represent the assigned fork epoch for peer das. | ||
| ForkVersionSchedule map[[fieldparams.VersionLength]byte]primitives.Epoch // Schedule of fork epochs by version. |
There was a problem hiding this comment.
Is it possible to keep the blank line between Eip7594ForkEpoch and ForkVersionSchedule so the whole block does not get rewritten by gofmt?
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
In preparation of eventually merging this into develop, we remove the use of the peerDAS flag and instead trigger it via the
EIP7594fork epoch. The reason this is done is mainly:Which issues(s) does this PR fix?
N.A
Other notes for review