-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name Changes to Align with V0.3 #1621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent_shuffling_epoch`, `current_shuffling_see`
Codecov Report
@@ Coverage Diff @@
## master #1621 +/- ##
==========================================
+ Coverage 71.06% 71.12% +0.05%
==========================================
Files 94 94
Lines 6628 6614 -14
==========================================
- Hits 4710 4704 -6
+ Misses 1505 1504 -1
+ Partials 413 406 -7 |
rauljordan
approved these changes
Feb 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to get this in soon to not have to resolve conflicts later, thanks for doing this big effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1542
Updated the following names:
SEED_LOOKAHEAD
->MIN_SEED_LOOKAHED
ENTRY_EXIT_DELAY
->ACTIVATION_EXIT_DELAY
INCLUDER_REWARD_QUOTIENT
->ATTESTATION_INCLUSION_REWARD_QUOTIENT
latest_index_roots
->latest_active_index_roots
current_epoch_start_shard
->current_shuffling_start_shard
,current_shuffling_epoch
,current_shuffling_seed
MIN_VALIDATOR_WITHDRAWAL_EPOCHS
->MIN_VALIDATOR_WITHDRAWAL_DELAY
MAX_WITHDRAWALS_PER_EPOCH
->MAX_EXIT_DEQUEUES_PER_EPOCH
ETH1_DATA_VOTING_PERIOD
->EPOCHS_PER_ETH1_VOTING_PERIOD
SLOT_DURATION
->SECONDS_PER_SLOT
EPOCH_LENGTH
->SLOTS_PER_EPOCH
Not Updated yet. Waiting for dicussion:
ChainStart
->Eth2Genesis
Reference: ethereum/consensus-specs#534