Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Changes to Align with V0.3 #1621

Merged
merged 23 commits into from
Feb 18, 2019
Merged

Name Changes to Align with V0.3 #1621

merged 23 commits into from
Feb 18, 2019

Conversation

terencechain
Copy link
Member

This is part of #1542

Updated the following names:

  • penalized -> slashed
  • exit -> voluntary exit
  • initial, startup -> genesis
  • SEED_LOOKAHEAD -> MIN_SEED_LOOKAHED
  • ENTRY_EXIT_DELAY -> ACTIVATION_EXIT_DELAY
  • INCLUDER_REWARD_QUOTIENT -> ATTESTATION_INCLUSION_REWARD_QUOTIENT
  • latest_index_roots -> latest_active_index_roots
  • current_epoch_start_shard -> current_shuffling_start_shard, current_shuffling_epoch, current_shuffling_seed
  • MIN_VALIDATOR_WITHDRAWAL_EPOCHS -> MIN_VALIDATOR_WITHDRAWAL_DELAY
  • MAX_WITHDRAWALS_PER_EPOCH -> MAX_EXIT_DEQUEUES_PER_EPOCH
  • ETH1_DATA_VOTING_PERIOD -> EPOCHS_PER_ETH1_VOTING_PERIOD
  • SLOT_DURATION -> SECONDS_PER_SLOT
  • EPOCH_LENGTH -> SLOTS_PER_EPOCH

Not Updated yet. Waiting for dicussion:

  • ChainStart -> Eth2Genesis
  • operations -> transactions

Reference: ethereum/consensus-specs#534

@terencechain terencechain added the Ready For Review A pull request ready for code review label Feb 16, 2019
@terencechain terencechain self-assigned this Feb 16, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #1621 into master will increase coverage by 0.05%.
The diff coverage is 87.74%.

@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
+ Coverage   71.06%   71.12%   +0.05%     
==========================================
  Files          94       94              
  Lines        6628     6614      -14     
==========================================
- Hits         4710     4704       -6     
+ Misses       1505     1504       -1     
+ Partials      413      406       -7

Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to get this in soon to not have to resolve conflicts later, thanks for doing this big effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants