Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some of client to v0.3 spec #1733

Merged

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented Feb 27, 2019

Part of #1542

This updates some segments of the client to the v0.3 spec, I was doing the validator spec changes and saw there were other changes needed.

Notable changes:

  • EpochLength -> SlotsPerEpoch
  • slotDuration -> secondsPerSlot (only a few)
  • CurrentBoundaryAttestations -> CurrentEpochBoundaryAttestations (let me know if this one isn't needed, I figured it should match the spec for consistency even if it's a little long)
  • PrevBoundaryAttestations -> PrevEpochBoundaryAttestations (same as above)
  • Some instances were still AttestationInfo instead of the current AttestationData

Doc changes:

  • ShardNumber -> Shard (only doc changes)
  • EpochNumber -> Epoch (only doc changes)
  • previous_shuffling_seed -> previous_epoch_seed (only doc changes)
  • previous_shuffling_seed -> previous_epoch_seed (only doc changes)

Also handles: 629, and 630, as requested in #1542 which are minimal changes.

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #1733 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1733   +/-   ##
=======================================
  Coverage   72.06%   72.06%           
=======================================
  Files         102      102           
  Lines        7252     7252           
=======================================
  Hits         5226     5226           
  Misses       1557     1557           
  Partials      469      469

Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@terencechain terencechain merged commit 136950e into prysmaticlabs:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants