Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Proto Lint Issues #3044

Merged
merged 6 commits into from Jul 22, 2019
Merged

Resolve Proto Lint Issues #3044

merged 6 commits into from Jul 22, 2019

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Jul 22, 2019

This PR skips running golangci-lint on generated proto files in our repo, as they are generated code, as well as regenerates and checks-in pb.go files to match latest proto schema. There were some mismatches in field names that would cause golangci-lint to fail in current master.

This moves the proto compatibility tests to a _compatibility folder, as those will be ignored by the go tool when performing a go get, preventing travis errors.

$ go help packages

Directory and file names that begin with "." or "_" are ignored
by the go tool, as are directories named "testdata".

@rauljordan rauljordan changed the title Skip Golangci-Lint for Proto Generated Files Resolve Proto Lint Issues Jul 22, 2019
@prestonvanloon
Copy link
Member

Please run goimports -w proto/**/*.go

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d5dcc25). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #3044   +/-   ##
========================================
  Coverage          ?   1.16%           
========================================
  Files             ?       7           
  Lines             ?     342           
  Branches          ?       0           
========================================
  Hits              ?       4           
  Misses            ?     338           
  Partials          ?       0

@rauljordan rauljordan added the Ready For Review A pull request ready for code review label Jul 22, 2019
@rauljordan rauljordan self-assigned this Jul 22, 2019
@rauljordan rauljordan merged commit 8cfbf03 into master Jul 22, 2019
@rauljordan rauljordan deleted the skip-proto-lint branch July 22, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants