Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap account creation errors #3156

Merged
merged 3 commits into from Aug 8, 2019
Merged

Wrap account creation errors #3156

merged 3 commits into from Aug 8, 2019

Conversation

terencechain
Copy link
Member

Use errors.Wrap for creating new validator account

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #3156 into master will decrease coverage by 21.64%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           master    #3156       +/-   ##
===========================================
- Coverage   48.28%   26.64%   -21.65%     
===========================================
  Files         115       54       -61     
  Lines        9035     2567     -6468     
===========================================
- Hits         4363      684     -3679     
+ Misses       3954     1805     -2149     
+ Partials      718       78      -640

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #3156 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3156   +/-   ##
=======================================
  Coverage   26.77%   26.77%           
=======================================
  Files          54       54           
  Lines        2577     2577           
=======================================
  Hits          690      690           
  Misses       1809     1809           
  Partials       78       78

@terencechain terencechain merged commit 2ec8a46 into master Aug 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-logging branch August 8, 2019 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants