Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beaconblock over wire #3436

Merged
merged 10 commits into from Sep 10, 2019
Merged

Beaconblock over wire #3436

merged 10 commits into from Sep 10, 2019

Conversation

shayzluf
Copy link
Contributor

[Part of] #3398


We have requested headslot as start slot in the beacon block request added +1 to request the block ahead

We have previously sent and expected BeaconBlockRespone over the wire while it contained protobuf fields that other client don't send or expect to get. we have fixed the way we un marshal it from the wire

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3708a8f). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #3436   +/-   ##
=========================================
  Coverage          ?   55.55%           
=========================================
  Files             ?        2           
  Lines             ?       63           
  Branches          ?        0           
=========================================
  Hits              ?       35           
  Misses            ?       16           
  Partials          ?       12

@prestonvanloon
Copy link
Member

Looking at this now, we can use interface{} instead of defining new methods specifically for blocks. Will push up shortly

@prestonvanloon
Copy link
Member

LGTM.

More context:
https://github.com/ethereum/eth2.0-specs/blob/3d97160098ab2c6d494dc4ce4d1a9bcbb429df6d/specs/networking/p2p-interface.md#encoding-strategies

For objects containing a single field, only the field is SSZ-encoded not a container with a single field. For example, the BeaconBlocks response would be an SSZ-encoded list of BeaconBlocks.

@terencechain terencechain merged commit 1edeb8e into master Sep 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the beaconblock_over_wire branch September 10, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants