New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beaconblock over wire #3436
Beaconblock over wire #3436
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3436 +/- ##
=========================================
Coverage ? 55.55%
=========================================
Files ? 2
Lines ? 63
Branches ? 0
=========================================
Hits ? 35
Misses ? 16
Partials ? 12 |
b3f696d
to
e487929
Compare
Looking at this now, we can use |
LGTM.
|
[Part of] #3398
We have requested headslot as start slot in the beacon block request added +1 to request the block ahead
We have previously sent and expected BeaconBlockRespone over the wire while it contained protobuf fields that other client don't send or expect to get. we have fixed the way we un marshal it from the wire