Check Last Finalized Epoch #357
Conversation
|
@rawfalafel I don't think @nisdas has finished this. He hasn't implemented Get the last finalized epoch from a peer from a received block + tests |
… into initialsync
… into initialsync
beacon-chain/sync/service.go
Outdated
| @@ -197,6 +252,116 @@ func (ss *Service) ReceiveActiveState(data *pb.ActiveStateResponse) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // SetBlockForInitalSync sets the first received block as the base finalized | |||
| // block for initial sync. | |||
| func (ss *Service) SetBlockForInitalSync(data *pb.BeaconBlockResponse) error { | |||
beacon-chain/sync/service_test.go
Outdated
| blockResponse.SlotNumber = 21 | ||
| ss.blockBuf <- msg1 | ||
|
|
||
| time.Sleep(interval) |
There was a problem hiding this comment.
If we're going to use an interval, please pass in the channel rather than putting in a 1 second timeout.
beacon-chain/sync/service.go
Outdated
|
|
||
| // SetBlockForInitalSync sets the first received block as the base finalized | ||
| // block for initial sync. | ||
| func (ss *Service) SetBlockForInitalSync(data *pb.BeaconBlockResponse) error { |
beacon-chain/sync/service_test.go
Outdated
|
|
||
| func TestTimeChan(t *testing.T) { | ||
| hook := logTest.NewGlobal() | ||
| interval := time.Duration(1000) |
There was a problem hiding this comment.
This can be avoided by passing the channel into the goroutine. We should really avoid adding extra time to the tests like this. They add up quickly.
beacon-chain/blockchain/service.go
Outdated
| if err != nil { | ||
| return false, err | ||
| } | ||
| if !hasActive && !hasCrystallized { |
There was a problem hiding this comment.
Should this be !hasActive || !hasCrystallized?
beacon-chain/sync/service.go
Outdated
| switch ss.syncMode { | ||
| case 0: | ||
| log.Info("Starting initial sync") | ||
| go ss.initialSync(ss.ctx.Done()) |
There was a problem hiding this comment.
do you disagree with this?
Codecov Report
@@ Coverage Diff @@
## master #357 +/- ##
=========================================
- Coverage 49.81% 49.8% -0.01%
=========================================
Files 35 35
Lines 2670 2795 +125
=========================================
+ Hits 1330 1392 +62
- Misses 1160 1206 +46
- Partials 180 197 +17
Continue to review full report at Codecov.
|
beacon-chain/sync/service.go
Outdated
| case 0: | ||
| log.Info("Starting initial sync") | ||
| go ss.initialSync(time.NewTicker(ss.syncPollingInterval).C, ss.ctx.Done()) | ||
| case 1: |
This pull request will deal with #351 , where we will determine the last finalized epoch of a connected peer and then start our sync from there.
Requirements for Merge