Part 1 of Aligning Core Blockchain Package with Latest 2.1 Spec #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
=========================================
- Coverage 54.24% 53.5% -0.74%
=========================================
Files 30 31 +1
Lines 2459 2493 +34
=========================================
Hits 1334 1334
- Misses 960 998 +38
+ Partials 165 161 -4
Continue to review full report at Codecov.
|
terencechain
changed the title
terencechain
requested review from
rauljordan,
nisdas,
rawfalafel and
prestonvanloon
rauljordan
requested changes
Aug 13, 2018
| @@ -36,6 +36,11 @@ type beaconState struct { | |||
| CrystallizedState *types.CrystallizedState | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
@rauljordan thanks for the review! it's ready again!
beacon-chain/blockchain/core.go
Outdated
| if err != nil { | ||
| return nil, -1, err | ||
| } | ||
| return indices[:int(attesterCount)], indices[len(indices)-1], nil | ||
| } | ||
|
|
||
| // getAttestersTotalDeposit returns the total deposit combined by attesters. | ||
| // TODO: Consider slashing condition |
beacon-chain/blockchain/core.go
Outdated
| } | ||
| } | ||
|
|
||
| // split the shuffled list for heights |
beacon-chain/blockchain/service.go
Outdated
| @@ -211,11 +211,17 @@ func (c *ChainService) run(done <-chan struct{}) { | |||
| log.Errorf("Write active state to disk failed: %v", err) | |||
| } | |||
|
|
|||
| currentSlot := block.SlotNumber() | |||
| // TODO: Apply 2.1 fork choice logic using the following | |||
rauljordan
approved these changes
Aug 14, 2018
|
I approve but it looks like we'll have to get coverage up by a lot in the blockchain package as it seems it has a lot of stuff untested. Maybe we can revisit that after the spec is a little bit more solid. |
|
I'll open a PR to improve the coverage tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of aligning beacon chain node code base with latest 2.1 spec. Following items got changed in this PR with respect to 2.1:
I don't want to put all the 2.1 changes in a single giant PR. Will be opening multiple small in regards to more 2.1 updates. Per blocking processing, cycle length recalculating, test coverage improvements will be coming next.
https://notes.ethereum.org/SCIg8AH5SA-O4C1G1LYZHQ?view