Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing codecov #375

Merged
merged 3 commits into from
Aug 7, 2018
Merged

Testing codecov #375

merged 3 commits into from
Aug 7, 2018

Conversation

prestonvanloon
Copy link
Member

I'm hoping to add some coverage reporting to our pull requests.

The goal is to show a delta on code coverage so that we can ensure that our code coverage is not getting worse over time.

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay coverage!

@prestonvanloon
Copy link
Member Author

This is failing tests with go test ./.... I think might be related data race issues in #377.

@prestonvanloon prestonvanloon added this to the Backlog milestone Aug 5, 2018
@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@7a1f586). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #375   +/-   ##
=========================================
  Coverage          ?   49.77%           
=========================================
  Files             ?       35           
  Lines             ?     2670           
  Branches          ?        0           
=========================================
  Hits              ?     1329           
  Misses            ?     1160           
  Partials          ?      181

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1f586...05627ad. Read the comment docs.

@rauljordan rauljordan merged commit 36965be into master Aug 7, 2018
@prestonvanloon prestonvanloon deleted the coverage branch December 1, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants