Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change BLS Library to Herumi #3752

Merged
merged 48 commits into from Nov 14, 2019
Merged

Change BLS Library to Herumi #3752

merged 48 commits into from Nov 14, 2019

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Oct 10, 2019 •
edited

  • Changes from Killic's BLS Library to herumi's
  • Use the bazelified fork of herumi's static library
  • Fix all tests

BenchMarks

Killic:
goos: linux
goarch: amd64
pkg: github.com/prysmaticlabs/prysm/shared/bls
BenchmarkSignature_VerifyAggregate-8   	     200	   6269728 ns/op	   52760 B/op	      70 allocs/op

Herumi:
goos: linux
goarch: amd64
pkg: github.com/prysmaticlabs/prysm/shared/bls
BenchmarkSignature_VerifyAggregate-8         640           2138095 ns/op            2824 B/op         16 allocs/op

@nisdas
change to herumi's bls
ab630ed
@nisdas
change alias
ec1ed8d
@nisdas
change to better
4f54ceb
@nisdas
add benchmark
7e2d53a
@nisdas
build
9d21f94
@nisdas
change to bazel fork
152f513
@nisdas
fix prefix
85cf91c
@nisdas
Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding…
e0c915c 
… into herumiBLS
@nisdas
make it work with library
e2c6473
@nisdas
update to latest
981099a
@nisdas
change again
c529522
@nisdas
add import
a323c71
@nisdas
update to latest
60acc6c
@nisdas
add sha commit
21c7751
@nisdas
new static lib with groups swapped
c3fa447
@nisdas
using herumis new lib
c84b715
@nisdas
fix dep paths in c headers
e521ee6
@nisdas
update again
6cde498
@nisdas
new changes
9ba53eb
@nisdas
fix commit
38b5d98
@nisdas
Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding…
00be32d 
… into herumiBLS
@nisdas
fix serialization
7b919ad
@nisdas
comment
6d3764c
@nisdas
fix test
f7d3294
@nisdas
Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding…
43f5e94 
… into herumiBLS
@nisdas
fix to herumis latest version
4c4a5c5
@nisdas
fix test
1c2de95
@nisdas
fix benchmarks
189a5f1
@nisdas
Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding…
fa21c95 
… into herumiBLS
@nisdas
Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding…
d849f7f 
… into herumiBLS
@nisdas nisdas added the Ready For Review A pull request ready for code review label Oct 28, 2019
@codecov
Copy link

codecov bot commented Nov 3, 2019 •
edited

Codecov Report

Merging #3752 into master will increase coverage by 1.34%.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##           master    #3752      +/-   ##
==========================================
+ Coverage   55.63%   56.97%   +1.34%     
==========================================
  Files         200      201       +1     
  Lines       12885    12386     -499     
==========================================
- Hits         7168     7057     -111     
+ Misses       4735     4349     -386     
+ Partials      982      980       -2

@stale
Copy link

stale bot commented Nov 10, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale There hasn't been any activity here in some time... label Nov 10, 2019
@rauljordan rauljordan removed the Stale There hasn't been any activity here in some time... label Nov 11, 2019
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@rauljordan rauljordan merged commit 2458386 into master Nov 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the herumiBLS branch November 14, 2019 15:51
nisdas pushed a commit that referenced this pull request Nov 14, 2019
Revert "Change BLS Library to Herumi (#3752)"
2e3f669 
This reverts commit 2458386.
@nisdas nisdas mentioned this pull request Nov 14, 2019
Merged
prestonvanloon pushed a commit that referenced this pull request Nov 14, 2019
@nisdas @prestonvanloon
Revert "Change BLS Library to Herumi (#3752)" (#4006)
904898e 
This reverts commit 2458386.
nisdas added a commit that referenced this pull request Nov 15, 2019
@nisdas
Revert "Revert "Change BLS Library to Herumi (#3752)" (#4006)"
4812647 
This reverts commit 904898e.
@nisdas nisdas mentioned this pull request Nov 15, 2019
Merged
1 task
rauljordan pushed a commit that referenced this pull request Nov 15, 2019
@nisdas @rauljordan
Reverts the Revert (#4011)
c4ca8a4 
* Revert "Revert "Change BLS Library to Herumi (#3752)" (#4006)"

This reverts commit 904898e.

* turn it on

* make all docker images with cgo deps static

* change back

* fix build

* switch back

* address gateway

* fix library again
@nisdas nisdas mentioned this pull request Dec 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@0xKiwi 0xKiwi 0xKiwi approved these changes

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nisdas @CLAassistant @rauljordan @0xKiwi @herumi