Add Solidity Linter to Travis #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
requested changes
Aug 4, 2018
.travis.yml
Outdated
| - os: linux | ||
| env: V=0.15.0 | ||
| before_install: | ||
| # Install Bazel | ||
| # Install Bazel and initialize solidity linter at the end |
There was a problem hiding this comment.
Revert this comment. The comment reflects what happens in this next step
There was a problem hiding this comment.
Add your npm step after the bazel installation step.
On line 51 add:
# Install solidity linter
- npm install -g solium
.travis.yml
Outdated
| @@ -9,11 +9,11 @@ matrix: | |||
| - lint | |||
| script: | |||
| - | |||
| go get github.com/alecthomas/gometalinter && gometalinter --install && gometalinter ./... --deadline=10m --exclude=client/internal/client_helper.go | |||
| npm install -g solium && go get github.com/alecthomas/gometalinter && gometalinter --install && gometalinter ./... --deadline=10m --exclude=client/internal/client_helper.go | |||
There was a problem hiding this comment.
Revert this. You're installing solium in the linter container and it won't be available to to the testing container.
.travis.yml
Outdated
| @@ -71,6 +71,9 @@ matrix: | |||
| # Check that target visibility is correct.. | |||
| - ./check_visibility.sh | |||
|
|
|||
| # Check solidity linter. | |||
| - solium -d contracts/ | |||
.travis.yml
Outdated
| @@ -71,6 +71,9 @@ matrix: | |||
| # Check that target visibility is correct.. | |||
There was a problem hiding this comment.
Can you fix this double .? Thanks!
|
Another thing you could do is to add another entry to the matrix. - os: linux
language: node_js
env:
- solidity
node_js:
- "lts/*"
before_install:
- npm install -g solium
install: true # Skip npm install
script:
# Check solidity linter.
- solium -d contracts/This build would run in parallel rather than sequential in the test container. |
prestonvanloon
approved these changes
Aug 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time playing Travis 馃槄 Apologize in advance for any obvious mistake. Let me know if anything is worng