Utilize New SSZ Caching of Arrays of Roots in Beacon Node Runtime #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
Closing for now - this caching approach is broken, unfortunately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tracking issue.
Description
Write why you are making the changes in this pull request
This PR integrates prysmaticlabs/go-ssz#91 into Prysm using a feature flag to enable the new SSZ cache.
Write a summary of the changes you are making
Updates workspace and adds the
--enable-ssz-cachefor the beacon node runtime.Link anything that would be helpful or relevant to the reviewers
Let's run this in an experimental node in our testnet cluster before attempting to update all nodes.