Remove Mainchain & Syncer Packages from Client #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
approved these changes
Aug 12, 2018
prestonvanloon
approved these changes
Aug 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 52.54% 54.48% +1.94%
==========================================
Files 33 29 -4
Lines 2695 2443 -252
==========================================
- Hits 1416 1331 -85
+ Misses 1108 955 -153
+ Partials 171 157 -14
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
Given the direction of the beacon chain + sharding spec, a client will no longer need to sync collation headers from the SMC and will no longer need access to a geth mainchain node. This PR removes these items and is part of the greater effort of #315.