Part 2 of Aligning Core Package with Latest 2.1 - Helper Functions #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 57.96% 57.96% +<.01%
==========================================
Files 31 31
Lines 2500 2510 +10
==========================================
+ Hits 1449 1455 +6
- Misses 881 884 +3
- Partials 170 171 +1
Continue to review full report at Codecov.
|
rauljordan
requested changes
Aug 17, 2018
beacon-chain/blockchain/core_test.go
Outdated
| if err := beaconChain.SetCrystallizedState(state); err != nil { | ||
| t.Fatalf("unable to mutate crystallized state: %v", err) | ||
| } | ||
| _, err := beaconChain.getIndicesForHeight(1000) |
There was a problem hiding this comment.
if _, err := ; err != nil {
| } | ||
|
|
||
| func TestGetBlockHash(t *testing.T) { | ||
| beaconChain, db := startInMemoryBeaconChain(t) |
There was a problem hiding this comment.
Can we use database.NewKVStore() from the shared/database package instead?
There was a problem hiding this comment.
It is using NewKvStore(). startInMemoryBeaconChain() sets config's InMemory to true
func NewDB(config *DBConfig) (*DB, error) {
...
if config.InMemory {
db._db = NewKVStore()
return db, nil
}
...
}
rauljordan
approved these changes
Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the following helper functions that got introduced in 2.1:
getIndicesByHeighttakes input height and returns the validator committee list of that height. The validator committee list consists of validator indices of different shards.getBlockHashtakes input height and returns the block hash of that given height.