-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Panic in ListValidatorBalances RPC #4051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Bug
Something isn't working
Priority: Medium
Medium priority item
Ready For Review
A pull request ready for code review
labels
Nov 19, 2019
rauljordan
requested review from
0xKiwi,
nisdas,
prestonvanloon,
shayzluf and
terencechain
November 19, 2019 16:17
Codecov Report
@@ Coverage Diff @@
## master #4051 +/- ##
=========================================
Coverage ? 57.63%
=========================================
Files ? 201
Lines ? 12961
Branches ? 0
=========================================
Hits ? 7470
Misses ? 4422
Partials ? 1069 |
shayzluf
previously approved these changes
Nov 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
prestonvanloon
approved these changes
Nov 21, 2019
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* adding default response * regression test for archival * include full regression test * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * listbal * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge refs/heads/master into resolve-panic-rpc
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* adding default response * regression test for archival * include full regression test * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * listbal * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge branch 'master' into resolve-panic-rpc * Merge refs/heads/master into resolve-panic-rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
Priority: Medium
Medium priority item
Ready For Review
A pull request ready for code review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #4020
Description
Write why you are making the changes in this pull request
This PR resolves a bug in in
ListValidatorBalances
that would lead to a panic at runtime when using archival functionality:Specifically, this would happen under the following conditions:
headState.Balances
, which might have len > archivedBalances at epoch 50archivedBalances[i]
, which would cause a panicWrite a summary of the changes you are making
The loop should be over the archived balances, not over
headState.Balances
. A regression test was added to ensure the proper default responses for both archival and regular functionality so this will never happen again.