Add Lock When Accessing Checkpoints #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nisdas
commented
Nov 22, 2019
nisdas
commented
- Adds locks for checkpoints so as to prevent data races
Codecov Report
@@ Coverage Diff @@
## master #4086 +/- ##
==========================================
- Coverage 60.39% 57.44% -2.96%
==========================================
Files 203 203
Lines 12818 13170 +352
==========================================
- Hits 7741 7565 -176
- Misses 4001 4525 +524
- Partials 1076 1080 +4 |
prestonvanloon
approved these changes
Nov 22, 2019
terencechain
added a commit
that referenced
this pull request
Nov 23, 2019
This reverts commit 2f39254.
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* fix data races * Merge branch 'master' into checkpointLock * Merge branch 'master' into checkpointLock * Merge refs/heads/master into checkpointLock
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Revert "Add Lock When Accessing Checkpoints (prysmaticlabs#4086)" This reverts commit 2f39254. * Merge branch 'master' into revert-4086-checkpointLock
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* fix data races * Merge branch 'master' into checkpointLock * Merge branch 'master' into checkpointLock * Merge refs/heads/master into checkpointLock
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Revert "Add Lock When Accessing Checkpoints (prysmaticlabs#4086)" This reverts commit 2f39254. * Merge branch 'master' into revert-4086-checkpointLock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.