Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new demo configuration targeting mainnet scale #4397

Merged
merged 31 commits into from
Jan 7, 2020
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
4835133
Add new demo configuration targeting mainnet, with 1/10th of the depo…
prestonvanloon Jan 3, 2020
11d519f
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 3, 2020
0c24304
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 3, 2020
6811e08
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 4, 2020
0bbb6f5
reduce quotant by 1/10th. Use 1/10th mainnet values
prestonvanloon Jan 4, 2020
9f5f8e1
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 4, 2020
114c169
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 4, 2020
f19d31a
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 4, 2020
e1ea5ec
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 4, 2020
a9acf77
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 4, 2020
56ddfcb
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 4, 2020
9640eb4
only change the inactivity quotant
prestonvanloon Jan 4, 2020
44697ef
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 5, 2020
70ba5e7
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 5, 2020
fe5fb90
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 5, 2020
2340946
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 5, 2020
bc1b12b
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 5, 2020
97a2464
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 5, 2020
498b61b
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
77fabae
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
2c0169a
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
257a873
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
1ba0dfa
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
56f72a4
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
20f44a3
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
291ff1d
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
63cfa1e
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 6, 2020
e723269
Merge branch 'v0.9.2' of github.com:prysmaticlabs/prysm into new-demo…
prestonvanloon Jan 7, 2020
651cda9
Merge branch 'new-demo-config' of github.com:prysmaticlabs/prysm into…
prestonvanloon Jan 7, 2020
280ef15
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 7, 2020
775ac3d
Merge refs/heads/v0.9.2 into new-demo-config
prylabs-bulldozer[bot] Jan 7, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions shared/params/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,18 +222,17 @@ func MainnetConfig() *BeaconChainConfig {
// DemoBeaconConfig retrieves the demo beacon chain config.
// Notable changes from minimal config:
// - Max effective balance is 3.2 ETH
// - Ejection threshold is 3.175 ETH
// - Genesis threshold is disabled (minimum date to start the chain)
// - Ejection threshold is 1.6 ETH
func DemoBeaconConfig() *BeaconChainConfig {
demoConfig := MinimalSpecConfig()
demoConfig.MinDepositAmount = 100
demoConfig := MainnetConfig()

demoConfig.MinDepositAmount = 0.1 * 1e9
demoConfig.MaxEffectiveBalance = 3.2 * 1e9
demoConfig.EjectionBalance = 3 * 1e9
demoConfig.EjectionBalance = 1.6 * 1e9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set it back to 1.6?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is mainnet configuration, except 1/10th of the deposits.
Everything else feels mainnet, activation/ejection times, penalties, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without proper incentive to reward validators participating well in testnet. Such low ejection balance will cause testnet to struggle and diverge from production environment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, which is why I am advocating for this change. Using the mainnet configuration threshold gives us the ability to test and detect this scenario. If it kills the testnet, then we get a great post-mortem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Although the scenario differs from production(because people will care to keep clients alive for as long as they can), but the end result is still the same. It's a good network fragmentation test

demoConfig.EffectiveBalanceIncrement = 0.1 * 1e9
demoConfig.Eth1FollowDistance = 16

// Increment this number after a full testnet tear down.
demoConfig.GenesisForkVersion = []byte{0, 0, 0, 3}
demoConfig.GenesisForkVersion = []byte{0, 0, 0, 4}

return demoConfig
}
Expand Down