Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and inconsistencies #4453

Merged
merged 4 commits into from Jan 8, 2020
Merged

Conversation

0xKiwi
Copy link
Contributor

@0xKiwi 0xKiwi commented Jan 8, 2020

This PR fixes typos in a few of the configs, removes redundant type casts, and removes unused code.

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6bdadc2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4453   +/-   ##
=========================================
  Coverage          ?   52.33%           
=========================================
  Files             ?      216           
  Lines             ?    14145           
  Branches          ?        0           
=========================================
  Hits              ?     7403           
  Misses            ?     5558           
  Partials          ?     1184

@0xKiwi 0xKiwi requested review from terencechain and nisdas and removed request for terencechain January 8, 2020 02:28
Copy link
Contributor

@rauljordan rauljordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! yay for code health

@rauljordan rauljordan merged commit b30a7d1 into prysmaticlabs:master Jan 8, 2020
@mcdee mcdee mentioned this pull request Jan 8, 2020
nisdas pushed a commit that referenced this pull request Jan 8, 2020
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Fix typos and inconsistencies

* igoimports

* Gazelle
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Fix typos and inconsistencies

* igoimports

* Gazelle
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
@0xKiwi 0xKiwi deleted the cleanup branch March 15, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants