Optimize ListBeaconCommittees to use committees cache #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
commented
Jan 9, 2020
| @@ -195,7 +195,7 @@ func (s *Service) initializeBeaconChain( | |||
| eth1data *ethpb.Eth1Data) error { | |||
| _, span := trace.StartSpan(context.Background(), "beacon-chain.Service.initializeBeaconChain") | |||
| defer span.End() | |||
| log.Info("Genesis time reached, starting the beacon chain") | |||
There was a problem hiding this comment.
Fixed this log where it says genesis time reached but it hasn't reach. The log is meant for initializing beacon genesis state
terencechain
changed the title
nisdas
approved these changes
Jan 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #4464 +/- ##
===========================================
+ Coverage 17.93% 40.14% +22.21%
===========================================
Files 193 193
Lines 13037 12825 -212
===========================================
+ Hits 2338 5149 +2811
+ Misses 10410 6800 -3610
- Partials 289 876 +587 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListBeaconCommitteesuses methodComputeCommitteewhich bypasses the committee cache. Instead it should use methodBeaconCommittee(where the cache is) andBeaconCommitteecallsComputeCommitteeunderneath.It also cleans up code path where we don't need to recalculate
epochOffsetandtotalCount, it's already taken care of byBeaconCommittee