Optimize Archival Assignment Retrieval #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4480 +/- ##
=========================================
Coverage ? 39.82%
=========================================
Files ? 193
Lines ? 13156
Branches ? 0
=========================================
Hits ? 5239
Misses ? 7029
Partials ? 888 |
rauljordan
requested changes
Jan 10, 2020
| AttesterSlot: attesterSlot, | ||
| ProposerSlot: proposerSlot, | ||
| PublicKey: headState.Validators[index].PublicKey, | ||
| assignment, ok := archivedAssingments[index] |
There was a problem hiding this comment.
Suggested change
| assignment, ok := archivedAssingments[index] | |
| assignment, ok := archivedAssignments[index] |
| } | ||
| proposerIndexToSlot[i] = slot | ||
| } | ||
|
|
||
| assingmentMap := make(map[uint64]*ethpb.ValidatorAssignments_CommitteeAssignment) |
rauljordan
approved these changes
Jan 11, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* optimize further * remove func * Merge branch 'master' into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * raul's review * Merge branch 'optimizeArchival' of https://github.com/prysmaticlabs/geth-sharding into optimizeArchival * preston's review
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* optimize further * remove func * Merge branch 'master' into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * Merge refs/heads/master into optimizeArchival * raul's review * Merge branch 'optimizeArchival' of https://github.com/prysmaticlabs/geth-sharding into optimizeArchival * preston's review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings down archival assignment retrieval response times by only iterating through committees once and storing them all in a map.