Tidy-up of BestFinalized #4505
Merged
Tidy-up of BestFinalized #4505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4505 +/- ##
=======================================
Coverage 43.33% 43.33%
=======================================
Files 193 193
Lines 12950 12950
=======================================
Hits 5612 5612
Misses 6388 6388
Partials 950 950 |
nisdas
reviewed
Jan 13, 2020
nisdas
approved these changes
Jan 13, 2020
prestonvanloon
approved these changes
Jan 13, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Tidy up BestFinalized * Ensure no more than maxPeers returned * Merge branch 'master' into bestfinalized * Merge branch 'master' into bestfinalized * Merge branch 'master' into bestfinalized * Merge branch 'master' into bestfinalized * Remove swap file * Provide potential PIDs array with capacity * Add test for trimming and ordering in BestFinalized * Merge branch 'master' into bestfinalized
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Tidy up BestFinalized * Ensure no more than maxPeers returned * Merge branch 'master' into bestfinalized * Merge branch 'master' into bestfinalized * Merge branch 'master' into bestfinalized * Merge branch 'master' into bestfinalized * Remove swap file * Provide potential PIDs array with capacity * Add test for trimming and ordering in BestFinalized * Merge branch 'master' into bestfinalized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4504 this patch tidies up
BestFinalized. The main focus is to reduce the number of calls to peer status info, but it also takes the opportunity to tweak the list of peers returned to ensure those with the highest finalized epochs are returned in preference to those with lower.Additional comments have been provided to help explain what the function is doing at each stage, as the prior version was somewhat opaque in its operation.