Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Capacity for Slices #4540

Merged
merged 5 commits into from Jan 14, 2020
Merged

Set Capacity for Slices #4540

merged 5 commits into from Jan 14, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Jan 14, 2020

  • This sets the capacity of slices beforehand so that memory isnt unecessary allocated in fetchBlockRootsBySlotRange

@nisdas nisdas added the Ready For Review A pull request ready for code review label Jan 14, 2020
rauljordan
rauljordan previously approved these changes Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6c6715b). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #4540   +/-   ##
=========================================
  Coverage          ?   49.51%           
=========================================
  Files             ?      193           
  Lines             ?    13016           
  Branches          ?        0           
=========================================
  Hits              ?     6445           
  Misses            ?     5519           
  Partials          ?     1052

@nisdas nisdas merged commit 0bee1de into master Jan 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the setCapacity branch January 14, 2020 06:44
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* set capacities

* make it more accurate

* resolve it
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* set capacities

* make it more accurate

* resolve it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants