ReceiveBlockNoPubsubForkchoice
should not update block tree cache
#4541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the bottleneck during round robin sync for
ReceiveBlockNoPubsubForkchoice
is updating filtered tree cache every slot. This is not needed as suggested by the method name, we do not care about fork choice nor compute for head duringReceiveBlockNoPubsubForkchoice
To fix this, we implemented
OnBlockCacheFilteredTree
which inheritsOnBlock
plus updating the filtered block tree cache. And makeOnBlockCacheFilteredTree
called fromReceiveBlockNoPubsub
. Much better looking flame: