Disable Fork Choice Feature Flag #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Priority: High
rauljordan
requested review from
terencechain,
prestonvanloon,
0xKiwi,
nisdas and
shayzluf
prestonvanloon
approved these changes
Jan 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #4574 +/- ##
=========================================
Coverage ? 57.03%
=========================================
Files ? 237
Lines ? 15887
Branches ? 0
=========================================
Hits ? 9061
Misses ? 5509
Partials ? 1317 |
terencechain
approved these changes
Jan 21, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tracking issue.
Description
Write why you are making the changes in this pull request
Sometimes in testing, we encounter that fork choice causes many deadlines to exceed in the beacon node. We need to disable it temporarily to get certain things to work. This PR adds an unsafe
--disable-fork-choice-unsafefeature flag to the beacon node.