Implement attester protection into validator client #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…protecc-attester-db
…protecc-attester-db
…protecc-attester-db
…protecc-attester
…protecc-attester
…protecc-attester
0xKiwi
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4598 +/- ##
========================================
Coverage ? 0.93%
========================================
Files ? 48
Lines ? 3423
Branches ? 0
========================================
Hits ? 32
Misses ? 3389
Partials ? 2 |
…protecc-attester
…protecc-attester
0xKiwi
requested review from
terencechain,
prestonvanloon and
rauljordan
and removed request for
terencechain
rauljordan
approved these changes
Jan 22, 2020
|
He protecc, he attacc, but most importantly, he ...? |
terencechain
approved these changes
Jan 22, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Add flag for attester protection * Remove flags * Add attestation history DB functions to validator client * Fix comments * Update interface to new funcs * Fix test * Add flags * Implement most of attester protection * Fix tests * Add test for pruning * Add more test cases for prunes * Remove todo comment * Fix comments * Rename functions * Fix logs Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Add flag for attester protection * Remove flags * Add attestation history DB functions to validator client * Fix comments * Update interface to new funcs * Fix test * Add flags * Implement most of attester protection * Fix tests * Add test for pruning * Add more test cases for prunes * Remove todo comment * Fix comments * Rename functions * Fix logs Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds attester protection into the validator client to ensure a validator will not sign any possible slashable votes. This will protect from double, surrounded, and surrounding attestations, enabled by the feature flag
--protect-attester.