Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire voluntary exits pool #4613

Merged
merged 15 commits into from Jan 22, 2020
Merged

Wire voluntary exits pool #4613

merged 15 commits into from Jan 22, 2020

Conversation

prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon commented Jan 22, 2020

Voluntary exits pool is used in pubsub, RPC, and forkchoice/block processing.

Next PR is to write validator command to initiate exits.

Part of #2766

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d28fd42). Click here to learn what that means.
The diff coverage is 4.76%.

@@            Coverage Diff            @@
##             master    #4613   +/-   ##
=========================================
  Coverage          ?   37.82%           
=========================================
  Files             ?      209           
  Lines             ?    14778           
  Branches          ?        0           
=========================================
  Hits              ?     5590           
  Misses            ?     8242           
  Partials          ?      946

@prestonvanloon prestonvanloon added Ready For Review A pull request ready for code review and removed In Progress labels Jan 22, 2020
@prestonvanloon prestonvanloon marked this pull request as ready for review January 22, 2020 21:51
@@ -51,6 +52,7 @@ type Server struct {
StateNotifier statefeed.Notifier
P2P p2p.Broadcaster
AttPool attestations.Pool
ExitPool *voluntaryexits.Pool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs gofmt

rauljordan
rauljordan previously approved these changes Jan 22, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 4aa7ebc into master Jan 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the wire-voluntary-exits branch January 22, 2020 22:27
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
* Hookup voluntary exits pool
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* fix tests
* Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* gofmt
* Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits
* gofmt
* gaz
* Merge refs/heads/master into wire-voluntary-exits
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
* Hookup voluntary exits pool
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* fix tests
* Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits
* Merge refs/heads/master into wire-voluntary-exits
* gofmt
* Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits
* gofmt
* gaz
* Merge refs/heads/master into wire-voluntary-exits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants