New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire voluntary exits pool #4613
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into wire-voluntary-exits
Codecov Report
@@ Coverage Diff @@
## master #4613 +/- ##
=========================================
Coverage ? 37.82%
=========================================
Files ? 209
Lines ? 14778
Branches ? 0
=========================================
Hits ? 5590
Misses ? 8242
Partials ? 946 |
prestonvanloon
added
Ready For Review
A pull request ready for code review
and removed
In Progress
labels
Jan 22, 2020
prestonvanloon
requested review from
terencechain,
rauljordan,
shayzluf,
0xKiwi and
nisdas
January 22, 2020 21:51
rauljordan
reviewed
Jan 22, 2020
beacon-chain/rpc/validator/server.go
Outdated
@@ -51,6 +52,7 @@ type Server struct { | |||
StateNotifier statefeed.Notifier | |||
P2P p2p.Broadcaster | |||
AttPool attestations.Pool | |||
ExitPool *voluntaryexits.Pool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs gofmt
rauljordan
previously approved these changes
Jan 22, 2020
0xKiwi
approved these changes
Jan 22, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Hookup voluntary exits pool * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * fix tests * Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * gofmt * Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits * gofmt * gaz * Merge refs/heads/master into wire-voluntary-exits
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Hookup voluntary exits pool * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * fix tests * Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits * Merge refs/heads/master into wire-voluntary-exits * gofmt * Merge branch 'wire-voluntary-exits' of github.com:prysmaticlabs/prysm into wire-voluntary-exits * gofmt * gaz * Merge refs/heads/master into wire-voluntary-exits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voluntary exits pool is used in pubsub, RPC, and forkchoice/block processing.
Next PR is to write validator command to initiate exits.
Part of #2766