Fix go pbs #4626
Merged
Fix go pbs #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@terencechain all files weren't updated for vary long time |
Codecov Report
@@ Coverage Diff @@
## master #4626 +/- ##
========================================
Coverage ? 0.93%
========================================
Files ? 48
Lines ? 3422
Branches ? 0
========================================
Hits ? 32
Misses ? 3388
Partials ? 2 |
nisdas
reviewed
Jan 23, 2020
nisdas
approved these changes
Jan 23, 2020
|
|
||
| # Copy pb.go files from bazel-bin to original folder where .proto is. | ||
|
|
||
| for (( i=0; i<${arraylength}; i++ )); | ||
| do | ||
| destination=${file_list[i]#*$searchstring} | ||
| chmod 755 "$destination" |
There was a problem hiding this comment.
any reason to change to 755 instead of 644 ?
There was a problem hiding this comment.
i had 755 and 555 in those directories . i just changed it to the one that worked
There was a problem hiding this comment.
i guess 644 would suffice. thanks
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* fix issues * fix go pbs * added services * added services * remove unused files * bring back used files * bring back db proto files * gaz * gaz and bring back faucet * gaz and bring back rpc * gaz and bring back rpc * gaz and bring back rpc * go imports * remove unused
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* fix issues * fix go pbs * added services * added services * remove unused files * bring back used files * bring back db proto files * gaz * gaz and bring back faucet * gaz and bring back rpc * gaz and bring back rpc * gaz and bring back rpc * go imports * remove unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix go pbs script to have the right destination path
Write why you are making the changes in this pull request
go pbs script was ditched by most services but is still used by slasher this pr attempt to fix it