Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deposit inclusion slot calculation #4635

Merged
merged 2 commits into from Jan 23, 2020
Merged

Fix deposit inclusion slot calculation #4635

merged 2 commits into from Jan 23, 2020

Conversation

mcdee
Copy link
Contributor

@mcdee mcdee commented Jan 23, 2020

The calculation of the voting period in seconds was incorrect, resulting in the wrong value being returned. This fixes the calculation.

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8197eff). Click here to learn what that means.
The diff coverage is 24.63%.

@@            Coverage Diff            @@
##             master    #4635   +/-   ##
=========================================
  Coverage          ?   20.92%           
=========================================
  Files             ?      192           
  Lines             ?    13369           
  Branches          ?        0           
=========================================
  Hits              ?     2797           
  Misses            ?    10105           
  Partials          ?      467

@0xKiwi 0xKiwi merged commit 0f27343 into prysmaticlabs:master Jan 23, 2020
@mcdee mcdee deleted the timefix branch February 5, 2020 09:23
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 24, 2020
cryptomental pushed a commit to cryptomental/prysm that referenced this pull request Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants