Part 2 of block chain service refactor - move process attestation #4672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4672 +/- ##
==========================================
+ Coverage 39.21% 39.28% +0.07%
==========================================
Files 198 200 +2
Lines 14356 14284 -72
==========================================
- Hits 5629 5611 -18
+ Misses 7759 7677 -82
- Partials 968 996 +28 |
0xKiwi
approved these changes
Jan 28, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current structure, fork choice is tightly coupled with block chain service,
beacon-chain/blockchain/forkchoiceinsidebeacon-chain/blockchain. There's important attestation processing logic inbeacon-chain/blockchain/forkchoicewhich needs to be stripped out without fork choice and moved one folder up tobeacon-chain/blockchainChange list:
process_attestation.gofrombeacon-chain/blockchain/forkchoicetobeacon-chain/blockchainprocess_attestation.gotoprocess_attestation_helper.goprocess_attestation_test.gofrombeacon-chain/blockchain/forkchoicetobeacon-chain/blockchain--proto-array-forkchoice, it won't affect regular run time