Validator status updates #4675
Merged
Validator status updates #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4675 +/- ##
=========================================
Coverage ? 54.07%
=========================================
Files ? 248
Lines ? 17773
Branches ? 0
=========================================
Hits ? 9611
Misses ? 6746
Partials ? 1416 |
0xKiwi
reviewed
Jan 30, 2020
0xKiwi
reviewed
Jan 30, 2020
0xKiwi
reviewed
Jan 30, 2020
Co-Authored-By: Ivan Martinez <ivanthegreatdev@gmail.com>
0xKiwi
reviewed
Jan 30, 2020
| ) | ||
|
|
||
| // GetBeaconConfig returns the configuration of the beacon chain as understood by this node. | ||
| func (bs *Server) GetBeaconConfig(ctx context.Context, _ *ptypes.Empty) (*ethpb.BeaconConfig, error) { |
There was a problem hiding this comment.
Was this part of the validator status changes in ethereumapis?
There was a problem hiding this comment.
No, but because that PR came in after the one that added GetBeaconConfig() the commit of ethereumapis that we pull in includes this. #4595 will fill this function in (at least, that's what it says it will do; at current the PR isn't populated with the required code).
0xKiwi
approved these changes
Jan 30, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Update ValidatorStatus to match Ethereum APIs * Tidy up status calculation * Merge branch 'master' into validator-status-updates * Merge branch 'master' into validator-status-updates * Update beacon-chain/rpc/beacon/config.go Co-Authored-By: Ivan Martinez <ivanthegreatdev@gmail.com> * Update test names
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Update ValidatorStatus to match Ethereum APIs * Tidy up status calculation * Merge branch 'master' into validator-status-updates * Merge branch 'master' into validator-status-updates * Update beacon-chain/rpc/beacon/config.go Co-Authored-By: Ivan Martinez <ivanthegreatdev@gmail.com> * Update test names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes up validator states to match those in ethereumapis after prysmaticlabs/ethereumapis#95