Add wallet keymanager #4687
Merged
Add wallet keymanager #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4687 +/- ##
=========================================
Coverage ? 29.39%
=========================================
Files ? 229
Lines ? 16967
Branches ? 0
=========================================
Hits ? 4988
Misses ? 11135
Partials ? 844 |
|
This PR should address #4683, amongst other things. |
nisdas
reviewed
Jan 31, 2020
nisdas
approved these changes
Jan 31, 2020
rauljordan
approved these changes
Feb 3, 2020
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Add wallet keymanager * Read keymanageropts from file if not JSON Co-authored-by: Nishant Das <nish1993@hotmail.com> Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Add wallet keymanager * Read keymanageropts from file if not JSON Co-authored-by: Nishant Das <nish1993@hotmail.com> Co-authored-by: Raul Jordan <raul@prysmaticlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "wallet" keymanager. The wallet structure is described in https://github.com/wealdtech/go-eth2-wallet and follows the relevant EIP standards for keystore v4 and associated files.
Not all functionality of the go-eth2-wallet is exposed through through the keymanager options, specifically for this release it is focused on a filesystem-based wallet without wallet-level encryption. Additional options can be added once this PR has bedded in.
Once this PR has been accepted I'll write up a HOW TO for end-to-end creation of withdrawal and validator keys, creation and broadcast of deposit transactions, and use of validator keys by the validator process.